Bosch Sensortec Community

    cancel
    Showing results for 
    Search instead for 
    Did you mean: 

    Minor bugs in BME280 linux_userspace example code

    Minor bugs in BME280 linux_userspace example code

    lindzey
    Occasional Visitor

    Thanks for providing high-quality driver + example code for this chip! It has made my job much easier 😃

    There were a handful of issues in linux_userspace.c that I had to fix before getting valid data:

    • linux_userspace had the wrong name for an ifdef: BME280_FLOAT_ENABLE needed to be BME280_DOUBLE_ENALBE.  PR#89
    • linux_userspace wasn't always using ioctl to set the slave address, so read/writes failed:  PR#92

    And a few things that I cleaned up:

    • linux_userspace didn't report read failures. PR#90
    • there was no need to link against wiringPi. PR#91

    I wasn't sure if y'all were open to external contributions, but I went ahead and submitted pull requests for all 4. I submitted them separately to make review as straightforward and independent as possible. Please let me know if you'd prefer them submitted differently.

    (I'm using I2C on an ODroid C-4 to read data from the sensor, but I don't think these changes have anything to do with the device used)

    2 REPLIES 2

    BSTRobin
    Community Moderator
    Community Moderator

    Hi lindzey,

    Thank for your kindly feedback. I will let our internal team know your pull reuest and evaluate it.

    kgoveas
    Community Moderator
    Community Moderator

    Hi @lindzey ,

    Thank you for the pull-request. Your changes have been reviewed and merged. 

    Icon--AD-black-48x48Icon--address-consumer-data-black-48x48Icon--appointment-black-48x48Icon--back-left-black-48x48Icon--calendar-black-48x48Icon--center-alignedIcon--Checkbox-checkIcon--clock-black-48x48Icon--close-black-48x48Icon--compare-black-48x48Icon--confirmation-black-48x48Icon--dealer-details-black-48x48Icon--delete-black-48x48Icon--delivery-black-48x48Icon--down-black-48x48Icon--download-black-48x48Ic-OverlayAlertIcon--externallink-black-48x48Icon-Filledforward-right_adjustedIcon--grid-view-black-48x48IC_gd_Check-Circle170821_Icons_Community170823_Bosch_Icons170823_Bosch_Icons170821_Icons_CommunityIC-logout170821_Icons_Community170825_Bosch_Icons170821_Icons_CommunityIC-shopping-cart2170821_Icons_CommunityIC-upIC_UserIcon--imageIcon--info-i-black-48x48Icon--left-alignedIcon--Less-minimize-black-48x48Icon-FilledIcon--List-Check-grennIcon--List-Check-blackIcon--List-Cross-blackIcon--list-view-mobile-black-48x48Icon--list-view-black-48x48Icon--More-Maximize-black-48x48Icon--my-product-black-48x48Icon--newsletter-black-48x48Icon--payment-black-48x48Icon--print-black-48x48Icon--promotion-black-48x48Icon--registration-black-48x48Icon--Reset-black-48x48Icon--right-alignedshare-circle1Icon--share-black-48x48Icon--shopping-bag-black-48x48Icon-shopping-cartIcon--start-play-black-48x48Icon--store-locator-black-48x48Ic-OverlayAlertIcon--summary-black-48x48tumblrIcon-FilledvineIc-OverlayAlertwhishlist