Bosch Shared
- Top Results
See all results
- About jrlemieux
- About jrlemieux
Turn on suggestions
Auto-suggest helps you quickly narrow down your search results by suggesting possible matches as you type.
Showing results for
About jrlemieux
since
02-09-2021
02-10-2021
jrlemieux
New Poster
4
Posts
0
Likes
0
Solutions
02-10-2021
08:47 PM
The bug is not fixed. Line 1141 reads: while ((tries) && (rslt == BME68X_OK)) This test is wrong, because the loop will not be performed if there was an error the first time the loop is executed. Lines 1207 to 1209 read: if (rslt == BME68X_OK) { dev->delay_us(BME68X_PERIOD_POLL, dev->intf_ptr); This is wrong because the wait should be done between the attemps when there is a failure, not a success. Finally, the rslt that is captured on line 1143 is checked too late. All the processing between lins 1153 to 1175 should not be execued when an error happens on line 1143. The check on line 1147 should be done at the start of the function, not in the loop. I feel that the current code has never neeb tested under a failure test case. Thank you. JL
... View more
02-10-2021
12:50 AM
Also, this code fills in the output "struct bme680_field_data *data" variable even when an error occurs upon a call to bme680_get_regs. The "rslt" status code should be checked just after the call and the error condition should be properly handled.
... View more
02-10-2021
12:42 AM
I'd like to have access to the source code of the BME680 BSEC library for the following reasons: (i) put the source code in our git folder, to let us rebuild the project from sources at any time in the future, possibly for a different architecture, (ii) look at the code to validate it for possible bugs, (iii) look at it to understand where it can wait, and if so, for how long, (iv) evaluate the possibility to move the air quality index computations on the edge computer or on the cloud server rather than on our IoT devices. If the source code is available somewhere, please let me know where it can be found. Thank you. JL Clarity IoT
... View more
02-10-2021
12:34 AM
In the file bme680.c on lines 1212 to 1215, we can read: rslt = null_ptr_check(dev); do { if (rslt == BME680_OK) { rslt = bme680_get_regs(((uint8_t) (BME680_FIELD0_ADDR)), buff, (uint16_t) BME680_FIELD_LENGTH, The issue is that the variable "rslt" is not altered further down the loop, so when there is an error the first time, "rslt" will be different than BME680_OK, so the "if" on line 1214 will always be false, and the bme680_get_regs function will never be called again. So at the end, this code will always try a maximum of 1 time. Thank you. JL, Clarity IoT
... View more
Latest Tags
No tags yet
Still looking for something?
- Top Results
See all results